Thank you for trusting your question to JA today. I am a licensed attorney with over a decade of law practice and over 20 years of experience in the legal field. I’m happy to be of assistance.
There is no expungement method for a federal conviction. It simply can't be done. A military conviction is a federal conviction, so the same rule applies. The only way to have a federal conviction, like a military one, removed is to file for a Presidential Pardon through the Department of Justice.
The confusion that you may be seeing here is the issue of states having a "rights restoration" rule, but that applies to their own state level felonies. The Supreme Court addressed that issue in a case from 1994, noting that states can't apply their own criteria for restoration of gun ownership rights as it pertains to federal convictions. They have to apply, instead, the criteria of the federal law and, because there isn't a federal restoration of gun rights process, not grant the restoration of gun rights.
The other area of confusion concerns state rights to vote, which are actually dictated by each state. Each state decides what they consider to be a felony and it differs slightly from state to state. There are times when one state considers a court martial conviction a felony, and others do not, so the person could have rights to vote restored in one state and not another (again, more confusion). This gets even more confusing when states consider whether or not the alleged crime is specifically a military vs. actual crime (AWOL for instance has no civilian corollary).
So, on the issue of voting, he just has to apply in the individual state that he is in and go through their restoration of voting rights process.
I'm not sure what you mean by saying that convicted felons can't own land. Yes, they may have issues obtaining jobs and loans, but there is no rule against owning land, unless convicted of a child pornography/sexual assault crime. Then the ownership of land near certain areas becomes an issue.
If you have any further questions or other facts that you would like me to consider, please let me know. I invite follow up questions, so use REPLY for those. If you have no further questions then good luck going forward and please do not forget to rate my service with a three, a four or preferably a five star rating so that I receive credit for working with you today. Please rate me based on my service and not on your satisfaction with the law, which I am not in control of and I am just reporting to you. Also, feel free to request me in the future, if you have questions concerning a different matter.