You certainly do have a lot going on so let me see if I can assist you.
If your attorney subpoenas photos, then you are entitled to them, unless the other side can say and establish they are not relevant. The subpoena is always served on to the attorneys.
I cannot say if your witnesses will also be deposed. It is possible. And, I don't know why they would depose your attorneys - are you talking about current counsel or past?
You evidence that your attorney wants you to maintain, notes of police visits without reports could help support an illegal search. If there was no search warrant then it was illegal
If they are requesting your personal notes, then you attorney can oppose that request. You do not need to turn anything over that your attorney can show is privileged or irrelevant
I cannot comment on another lawsuit and whether or how it would be beneficial to you, because I am not privy to the facts of matters of that case. Actually, I can only offer guidance here as I am not privy to all your facts and matters